Review Request 128627: avoid crash starting kate with QT_FATAL_WARNINGS=1

[Jaime Torres Amate]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128627/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kio


Description
-------

avoid connecting KUrl from null


Diffs
-----

  src/widgets/kurlrequester.cpp 77e7c1d 

Diff: https://git.reviewboard.kde.org/r/128627/diff/


Testing
-------

before the patch, there was 4 connect(null, .....), that crashed within:

#0  0x00007ffff441f975 in __GI_raise (sig=sig at entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1  0x00007ffff4420d8a in __GI_abort () at abort.c:78
#2  0x00007ffff50ca6e5 in QMessageLogger::warning(char const*, ...) const (context=..., message=...)
    at global/qlogging.cpp:1648
#3  0x00007ffff50ca6e5 in QMessageLogger::warning(char const*, ...) const (this=this at entry=0x7fffffffc270, msg=msg at entry=0x7ffff5412a58 "QObject::connect: invalid null parameter") at global/qlogging.cpp:557
#4  0x00007ffff52ec011 in QObjectPrivate::connectImpl(QObject const*, int, QObject const*, void**, QtPrivate::QSlotObjectBase*, Qt::ConnectionType, int const*, QMetaObject const*) (sender=sender at entry=0x0, signal_index=<optimized out>, receiver=receiver at entry=0xb7c970, slot=slot at entry=0x7fffffffc420, slotObj=slotObj at entry=0xb58500, type=Qt::AutoConnection, types=0x0, senderMetaObject=0x7ffff6a81900 <QLineEdit::staticMetaObject>) at kernel/qobject.cpp:4674
#5  0x00007ffff52ec2d2 in QObject::connectImpl(QObject const*, void**, QObject const*, void**, QtPrivate::QSlotObjectBase*, Qt::ConnectionType, int const*, QMetaObject const*) (sender=sender at entry=0x0, signal=signal at entry=0x7fffffffc410, receiver=receiver at entry=0xb7c970, slot=slot at entry=0x7fffffffc420, slotObj=0xb58500, type=Qt::AutoConnection, types=0x0, senderMetaObject=0x7ffff6a81900 <QLineEdit::staticMetaObject>)
    at kernel/qobject.cpp:4658
#6  0x00007ffff7ef2465 in KUrlRequester::KUrlRequesterPrivate::init() (type=Qt::AutoConnection, slot=
    (void (KUrlRequester::*)(KUrlRequester * const, const QString &)) 0x7ffff7eee1c0 <KUrlRequester::textChanged(QString const&)>, receiver=0xb7c970, signal=
    (void (QLineEdit::*)(QLineEdit * const, const QString &)) 0x7ffff64d34b0 <QLineEdit::textChanged(QString const&)>, sender=0x0) at /usr/include/qt5/QtCore/qobject.h:239

applying the patch, kate starts (there is no connect from null)


Thanks,

Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160808/f69ebe4e/attachment.html>