Review Request 128581: Make the default KMessageBoxDontAskAgainMemoryStorage save to QSettings

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128581/#review98130
-----------------------------------------------------------


Fix it, then Ship it!





src/kmessagebox_p.cpp (line 40)
<https://git.reviewboard.kde.org/r/128581/#comment66087>

    space after foreach -- or use range for



src/kmessagebox_p.cpp (line 41)
<https://git.reviewboard.kde.org/r/128581/#comment66086>

    That should be m_saved.insert(key, ...)
    
    (Effective STL, item 24, or see http://stackoverflow.com/questions/4934321/what-is-the-difference-between-using-insert-function-when-using-stdmap-insert)


- David Faure


On Aug. 4, 2016, 10:40 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128581/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2016, 10:40 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Feck, David Faure, and Kevin Ottens.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> Otherwise if you don't have the framework integration plugin installed, the messageboxes appear again and again and again even if the user continuously clicks "Don't show again".
> 
> See "KMessageBox runtime dependency on FrameworkIntegrationPlugin makes it useless" thread in kde-frameworks-devel mailing list for more information.
> 
> 
> Diffs
> -----
> 
>   src/kmessagebox_p.cpp 896cdb7 
> 
> Diff: https://git.reviewboard.kde.org/r/128581/diff/
> 
> 
> Testing
> -------
> 
> Tried rsibreak without the framework integration plugin, worked.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160805/c2497cd9/attachment.html>