Review Request 128597: support a size for adding applets

[Marco Martin]

> On Aug. 4, 2016, 1:28 p.m., David Edmundson wrote:
> > src/scriptengines/qml/plasmoid/containmentinterface.cpp, line 248
> > <https://git.reviewboard.kde.org/r/128597/diff/3/?file=472990#file472990line248>
> >
> >     QSize::isNull
> >     
> >     "Returns true if both the width and height is 0; otherwise returns false."
> >     
> >     You're passing it QSize(-1,-1)
> >     
> >     have you tested if it works?

indeed it didn't sorry about that :/


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128597/#review98103
-----------------------------------------------------------


On Aug. 4, 2016, 9:11 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128597/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2016, 9:11 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> in the addapplet signal, support size paramenters as well, to specify a full geometry where you want the plasmoid.
> 
> 
> Diffs
> -----
> 
>   src/scriptengines/qml/plasmoid/containmentinterface.h 8236105 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp c390ad1 
> 
> Diff: https://git.reviewboard.kde.org/r/128597/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160804/07c3b139/attachment.html>