Review Request 128595: [KUnitConversion] Add British "stone" unit of mass
David Jarvie
djarvie at kde.org
Thu Aug 4 16:32:55 UTC 2016
> On Aug. 3, 2016, 10:18 p.m., David Edmundson wrote:
> > src/mass.cpp, line 268
> > <https://git.reviewboard.kde.org/r/128595/diff/1/?file=472928#file472928line268>
> >
> > one of these should be "%1 stones" (with extra 's')
No, it's normally 'stone' for the plural as well.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128595/#review98074
-----------------------------------------------------------
On Aug. 3, 2016, 7:45 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128595/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2016, 7:45 p.m.)
>
>
> Review request for KDE Frameworks and David Edmundson.
>
>
> Repository: kunitconversion
>
>
> Description
> -------
>
> This weird unit is pretty common in the UK and equal to 6.35029318 kg.
>
>
> Diffs
> -----
>
> src/mass.cpp c7bf147
> src/unit.h e440346
>
> Diff: https://git.reviewboard.kde.org/r/128595/diff/
>
>
> Testing
> -------
>
> This is the type of stone you use to smash display windows.
>
> https://en.wikipedia.org/wiki/Stone_(unit)
>
> Verified that krunner spit out the same result as Google converter did.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160804/5afa0cf3/attachment.html>
More information about the Kde-frameworks-devel
mailing list