Review Request 128599: Improve kpackage_install_package

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128599/#review98102
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On Aug. 4, 2016, 12:18 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128599/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2016, 12:18 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kpackage
> 
> 
> Description
> -------
> 
> * Make sure we don't just append to the regenerateindex.sh file but refresh it on every configure execution.
> * Don't call generate every time when we configure. It's bound to break on systems that install in /usr.
> * Use the KF5::kpackagetool5 imported target rather than trying to figure out where it went.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 312be78 
>   KF5PackageMacros.cmake 81379c4 
>   src/kpackagetool/CMakeLists.txt f0c40ee 
> 
> Diff: https://git.reviewboard.kde.org/r/128599/diff/
> 
> 
> Testing
> -------
> 
> Things now install properly.
> The regenerateindex.sh files now make some sense.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160804/c5562279/attachment.html>