Review Request 128581: Make the default KMessageBoxDontAskAgainMemoryStorage save to QSettings

Albert Astals Cid aacid at kde.org
Wed Aug 3 22:12:44 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128581/
-----------------------------------------------------------

(Updated Aug. 3, 2016, 10:12 p.m.)


Review request for KDE Frameworks, Christoph Feck, David Faure, and Kevin Ottens.


Changes
-------

Move constructFilePath to private


Repository: kwidgetsaddons


Description
-------

Otherwise if you don't have the framework integration plugin installed, the messageboxes appear again and again and again even if the user continuously clicks "Don't show again".

See "KMessageBox runtime dependency on FrameworkIntegrationPlugin makes it useless" thread in kde-frameworks-devel mailing list for more information.


Diffs (updated)
-----

  src/kmessagebox_p.cpp 896cdb7 

Diff: https://git.reviewboard.kde.org/r/128581/diff/


Testing
-------

Tried rsibreak without the framework integration plugin, worked.


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160803/679d0941/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list