Review Request 128527: FileUndoManager: Undoing symlink creation

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128527/#review98068
-----------------------------------------------------------




src/widgets/fileundomanager.cpp (line 421)
<https://git.reviewboard.kde.org/r/128527/#comment66049>

    "I guess" isn't good enough for me, it's the point I want to clarify :-)
    
    I now did some research.
    
    Thanks for reminding me of the Copy-Job based KIO::link.
    That one is supported by FileUndoManager (since it emits copyingLinkDone)... and in fact it's what we should be using in knewfilemenu.cpp, because it also supports popping up the "rename" dialog when trying to create a symlink with a name that already exists.
    
    KIO::symlink is the low-level operation, KIO::link is the high-level operation, with support for conflict-handling and undo.
    
    I think the real fix here is to change knewfilemenu.cpp - and the fileundomanager unittest - to use KIO::link. With a bit of luck, no change will be needed in fileundomanager itself ;-)
    
    Can you give it a try?


- David Faure


On July 31, 2016, 9:28 a.m., Chinmoy Ranjan Pradhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128527/
> -----------------------------------------------------------
> 
> (Updated July 31, 2016, 9:28 a.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez, David Faure, Eike Hein, and Wolfgang Bauer.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> This patch adds the support for undoing creation of new symlinks.
> 
> 
> Diffs
> -----
> 
>   autotests/fileundomanagertest.h c663f92 
>   autotests/fileundomanagertest.cpp 761cc76 
>   src/filewidgets/knewfilemenu.cpp bb6fc04 
>   src/widgets/fileundomanager.cpp ed5edb0 
> 
> Diff: https://git.reviewboard.kde.org/r/128527/diff/
> 
> 
> Testing
> -------
> 
> build
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160803/65b9151c/attachment-0001.html>