Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128576/
-----------------------------------------------------------

(Updated Aug. 3, 2016, 11:34 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
-------

Submitted with commit 4d355569eea2fae76ed67f791db8abeec1e794f0 by Martin Gräßlin to branch master.


Bugs: 362531
    https://bugs.kde.org/show_bug.cgi?id=362531


Repository: kwindowsystem


Description
-------

The Xcb implementation of KWindowSystem has two operations modes and when
switching between the two it recreates the NETEventFilter.

This could result in the compositingChanged signal never to be emitted if:
1) NETEventFilter gets created before compositor is started
2) NETEventFilter gets recreated after compositor is started but before
   the old filter had a chance to process the XFixes event

This was the cause for e.g. plasmashell not properly detecting that a
Compositor is running on X11.

This change ensures that the signal is emitted if the compositing state
differs after the recreation. Also a test case is added which simulates
the condition.

BUG: 362531


Diffs
-----

  autotests/CMakeLists.txt 690c41bfe2ca981d206c590c3fbd28416d4ae401 
  autotests/compositingenabled_test.cpp PRE-CREATION 
  src/platforms/xcb/kwindowsystem.cpp fbff381b61116c6eef47d5c7fa1fc5730857328c 

Diff: https://git.reviewboard.kde.org/r/128576/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160803/8bd6e8b4/attachment-0001.html>