Review Request 128581: Make the default KMessageBoxDontAskAgainMemoryStorage save to QSettings

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128581/#review98034
-----------------------------------------------------------



You also tested with kmessageboxtest, right?


src/kmessagebox_p.cpp (line 37)
<https://git.reviewboard.kde.org/r/128581/#comment66027>

    Could be private



src/kmessagebox_p.cpp (line 42)
<https://git.reviewboard.kde.org/r/128581/#comment66026>

    Nitpick: generally the ctor and dtor come first.



src/kmessagebox_p.cpp (line 92)
<https://git.reviewboard.kde.org/r/128581/#comment66028>

    Might be a somewhat common scenario, I'm not sure we want to issue a warning unconditionally.


- Kevin Ottens


On Aug. 2, 2016, 10:27 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128581/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2016, 10:27 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Feck, David Faure, and Kevin Ottens.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> Otherwise if you don't have the framework integration plugin installed, the messageboxes appear again and again and again even if the user continuously clicks "Don't show again".
> 
> See "KMessageBox runtime dependency on FrameworkIntegrationPlugin makes it useless" thread in kde-frameworks-devel mailing list for more information.
> 
> 
> Diffs
> -----
> 
>   src/kmessagebox_p.cpp 896cdb7 
> 
> Diff: https://git.reviewboard.kde.org/r/128581/diff/
> 
> 
> Testing
> -------
> 
> Tried rsibreak without the framework integration plugin, worked.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160803/b82666f0/attachment-0001.html>