Review Request 128583: Make KrossUi and the command-line tool optional

[Aleix Pol Gonzalez]

> On Aug. 3, 2016, 3:28 a.m., Aleix Pol Gonzalez wrote:
> > Why?
> 
> Alexander Potashev wrote:
>     To make Kross easier to build for exotic (= non-Linux) platforms. (We have no actual users for these options yet.)

My experience says this tends to complicate the usage of the frameworks, especially when it includes different targets being offered depending on how it's built.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128583/#review98025
-----------------------------------------------------------


On Aug. 3, 2016, 1:36 a.m., Alexander Potashev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128583/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2016, 1:36 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kross
> 
> 
> Description
> -------
> 
> Make KrossUi and the command-line tool optional
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6bf66a6d73a20077f223c3cf9bfd642935e85da4 
>   src/CMakeLists.txt 6f715fae9049e0b9c6327ff505b0b27351ec0f67 
>   src/modules/CMakeLists.txt 48e2c0219072b1b1335821b0290d261d8dc3d361 
> 
> Diff: https://git.reviewboard.kde.org/r/128583/diff/
> 
> 
> Testing
> -------
> 
> Still compiles successfully in all 4 configurations: {BUILD_KROSSUI = ON, OFF} x {BUILD_KROSS_CLI = ON, OFF}.
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160803/bbaf066d/attachment.html>