Review Request 128566: [xcb] Use a KSelectionWatcher to monitor the compositing selection

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128566/
-----------------------------------------------------------

(Updated Aug. 2, 2016, 4:26 p.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks.


Repository: kwindowsystem


Description
-------

So far KWindowSystem had a custom implementation to monitor the
compositing selection using XFixes and an own event filter. This
change simplifies it by porting to KSelectionWatcher to share more
code. While the XFixes approach is actually better it's also fighting
with Qt which might result in events getting lost. At least we have
reports about the code being racy at startup.


Diffs
-----

  autotests/kwindoweffectstest.cpp 921bdb60d2ff0bd33f6dede9b4ca999740eb1eeb 
  src/platforms/xcb/kwindowsystem.cpp fbff381b61116c6eef47d5c7fa1fc5730857328c 
  src/platforms/xcb/kwindowsystem_p_x11.h 72df642bef4b3562dd44882a94661476a9772c2b 

Diff: https://git.reviewboard.kde.org/r/128566/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160802/8201f708/attachment.html>