Review Request 127236: Leverage QDir to know what's in a KIconThemeDir

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127236/
-----------------------------------------------------------

(Updated April 30, 2016, 3:44 a.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks and Christoph Feck.


Repository: kiconthemes


Description
-------

At the moment we're playing Battleship to see if an icon is present in a subdirectory. This means that we are checking on every directory if there's an icon that matches the size with a said name on every request.

This can be seen easily with strace:
```
$ strace kwrite |& grep ENOENT | wc -l
6212
```
After the patch: 
```
$ strace kwrite |& grep ENOENT | wc -l
1993
```
We reduce these accesses to let QDir keep the list of files inside the directory (that was already being generated at some point, it just was being discarded).


Diffs
-----

  src/kicontheme.cpp 0996054 

Diff: https://git.reviewboard.kde.org/r/127236/diff/


Testing
-------

Builds, tests still pass, applications start noticeably faster.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160430/1b74c11c/attachment.html>