Review Request 127788: Fix leak in KNS::Engine

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127788/#review95033
-----------------------------------------------------------


Fix it, then Ship it!





src/core/engine.cpp (line 155)
<https://git.reviewboard.kde.org/r/127788/#comment64498>

    I'd add a
    delete m_atticaProviderManager;
    prior to this line just in case.


- Albert Astals Cid


On April 29, 2016, 12:45 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127788/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 12:45 p.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> A local variable was shadowing the actual variable declaration.
> 
> 
> Diffs
> -----
> 
>   src/core/engine.cpp c8d0579 
> 
> Diff: https://git.reviewboard.kde.org/r/127788/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160429/dd114565/attachment-0001.html>