Review Request 127774: Load protocol info as a simple config.
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Apr 27 22:20:19 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127774/#review94925
-----------------------------------------------------------
+1
- Aleix Pol Gonzalez
On April 27, 2016, 11:53 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127774/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 11:53 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> Protocol information is loaded from a full path on the system. It
> doesn't make sense to also load either the user or system's kdeglobals.
>
> This saves parsing kdeglobals ~40 times (see thread in /r/127765)
>
>
> Diffs
> -----
>
> src/core/kprotocolinfo.cpp 17f8e9d66bdc9ef257fda6490e9278ec6de79b5a
>
> Diff: https://git.reviewboard.kde.org/r/127774/diff/
>
>
> Testing
> -------
>
> Dolphin still loads..
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160427/696837bb/attachment.html>
More information about the Kde-frameworks-devel
mailing list