Review Request 127763: Reduce memory usage footprint
Kai Uwe Broulik
kde at privat.broulik.de
Wed Apr 27 14:37:44 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127763/#review94907
-----------------------------------------------------------
src/kicontheme.cpp (line 696)
<https://git.reviewboard.kde.org/r/127763/#comment64441>
While at it you could also cache end()
- Kai Uwe Broulik
On April 27, 2016, 1:10 nachm., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127763/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 1:10 nachm.)
>
>
> Review request for KDE Frameworks and Christoph Feck.
>
>
> Repository: kiconthemes
>
>
> Description
> -------
>
> Leverages the implicitly shared nature of QString by only constructing the paths when it's strictly necessary. It souldn't show a big performance impact since the generated paths were only intermediate in most cases after all.
>
> This is especially important now that plasma has several KIconLoader instances at the same time, but it should have an impact on every application using kiconthemes (or under the plasma-integration effects).
>
>
> Diffs
> -----
>
> src/kicontheme.cpp 735ecf7
>
> Diff: https://git.reviewboard.kde.org/r/127763/diff/
>
>
> Testing
> -------
>
> Tests still pass, apps still work.
>
> Starting and closing dolphin under callgrind showed 1640M instructions, now 1466M(10% improvement).
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160427/de398a93/attachment.html>
More information about the Kde-frameworks-devel
mailing list