KF5 Tags tag tags, not objects

[Stephen Kelly]

David Faure wrote:

> versionfile=$here/versions/$repo
> if [ ! -f $versionfile ]; then echo "$versionfile not found"; exit 1; fi
> b=`sed '2q;d' $versionfile`
> echo $b
> checkout=$(findCheckout $repo)
> cd $checkout || exit 2
> echo $PWD
> $cmd git fetch --tags || exit 2
> $cmd git tag -a $tagname $b

The $b here is the cause. I don't have the versionfile. It seems it gets 
created by the pack.sh? Does it contain tags? That would be the cause of 
this if it does. The pack.sh seems to call a get_git_rev tool which I don't 
have.

I tried running 

 ./pack.sh kitemmodels -f

but it exits without printing anything.

A naive fix for this might be 

diff --git a/tag_all.sh b/tag_all.sh
index 16f3ab9..defca67 100755
--- a/tag_all.sh
+++ b/tag_all.sh
@@ -21,6 +21,7 @@ cat $here/modules.git | while read repo branch; do
     versionfile=$here/versions/$repo
     if [ ! -f $versionfile ]; then echo "$versionfile not found"; exit 1; 
fi
     b=`sed '2q;d' $versionfile`
+    b=`git rev-parse $b`
     echo $b
     if [ -d frameworks/$repo ]; then
         cd frameworks/$repo

but I didn't test it.

I guess we have an explanation though.

Thanks,

Steve.