Review Request 127632: Prioritize correct extension per theme

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127632/
-----------------------------------------------------------

(Updated April 27, 2016, 12:36 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Andreas Kainz and Christoph Feck.


Changes
-------

Submitted with commit 536d707981ada478b583f91f31a9dca741881a36 by Aleix Pol to branch master.


Repository: kiconthemes


Description
-------

Usually themes will have 1 kind of extension (2 tops) it doesn't make sense to bindly use an extensions vector that is statically defined.

Prioritizes the extensions that work, so it will find the icons sooner.


Diffs
-----

  src/kiconengine.h 5b9badb 
  src/kiconloader.cpp 37528ad 
  src/kicontheme.h 3190665 
  src/kicontheme.cpp e7e003b 

Diff: https://git.reviewboard.kde.org/r/127632/diff/


Testing
-------

Builds and tests still pass.
Also reducess faulty disk accesses to its 45%. Note that by this metric, it's almost as good as the RR #127236, but with a much smaller memory impact, since we're not caching all the icon names (which was specially bad as it was per-process).
```
$ strace kwrite |& grep ENOENT | wc -l
4699
$ strace kwrite |& grep ENOENT | wc -l
2119
```


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160426/7a765644/attachment.html>