Review Request 127699: Set the xscreensaver plugin as valid only if the dbus interface org.freedesktop.ScreenSaver is present
Paulo Lieuthier
paulolieuthier at gmail.com
Sat Apr 23 12:26:54 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127699/#review94780
-----------------------------------------------------------
Plasma itself will probably not benefit from this, because it will always have a screen locker (so org.freedesktop.ScreenSaver will always be present), but other environments, like LXQt, which currently has no screen locker, need this fix.
- Paulo Lieuthier
On April 20, 2016, 1:54 p.m., Paulo Lieuthier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127699/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 1:54 p.m.)
>
>
> Review request for KDE Frameworks and Martin Gräßlin.
>
>
> Repository: kidletime
>
>
> Description
> -------
>
> If the dbus interface org.freedesktop.ScreenSaver is not present, it makes no sense to use the plugin.
>
>
> Diffs
> -----
>
> src/plugins/xscreensaver/xscreensaverbasedpoller.h 05b9a23
> src/plugins/xscreensaver/xscreensaverbasedpoller.cpp f56396c
> src/widgetbasedpoller.h 68fc7dc
>
> Diff: https://git.reviewboard.kde.org/r/127699/diff/
>
>
> Testing
> -------
>
> Tested minimal application using KIdleTime using the xscreensaver plugin.
>
>
> Thanks,
>
> Paulo Lieuthier
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160423/678fe0d2/attachment.html>
More information about the Kde-frameworks-devel
mailing list