Review Request 127632: Prioritize correct extension per theme

[Albert Astals Cid]

> On April 11, 2016, 10:44 p.m., Albert Astals Cid wrote:
> > I'm unconvinced, actually the spec mentions order to be "Changed search order to png, svg, xpm"
> 
> Albert Astals Cid wrote:
>     https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html
> 
> Aleix Pol Gonzalez wrote:
>     I see, I didn't know that. Still, I believe we should adopt the patch for better performance.
>     
>     This will be a problem only if there's some icons that are in svg (or xpm) and not in png, but the rest do have png.

Honestly i'd prefer adding an extension to the .desktop of the icon theme called X-KDE-Extensions that lists the order in which extensions are checked and that for our themes we just set to svg. But if other people think adhering to the spec is not important i can live with it too.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127632/#review94547
-----------------------------------------------------------


On April 11, 2016, 11:17 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127632/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 11:17 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> Usually themes will have 1 kind of extension (2 tops) it doesn't make sense to bindly use an extensions vector that is statically defined.
> 
> Prioritizes the extensions that work, so it will find the icons sooner.
> 
> 
> Diffs
> -----
> 
>   src/kiconloader.cpp 37528ad 
>   src/kicontheme.h 3190665 
>   src/kicontheme.cpp e7e003b 
> 
> Diff: https://git.reviewboard.kde.org/r/127632/diff/
> 
> 
> Testing
> -------
> 
> Builds and tests still pass.
> Also reducess faulty disk accesses to its 45%. Note that by this metric, it's almost as good as the RR #127236, but with a much smaller memory impact, since we're not caching all the icon names (which was specially bad as it was per-process).
> ```
> $ strace kwrite |& grep ENOENT | wc -l
> 4699
> $ strace kwrite |& grep ENOENT | wc -l
> 2119
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160418/9ec52a19/attachment-0001.html>