Review Request 127666: kconfig and kurlrequester friendship: store local paths in string-typed item without file:// prefix

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127666/#review94676
-----------------------------------------------------------



-2

The bug is in some layer above this. If you use ItemUrl you get a URL, if you use ItemString, you can store whatever you want into it - including making sure that you always store a local path. Show me the relevant part of the ktorrent code that uses kcfg if you need help.

- David Faure


On April 17, 2016, 11:09 a.m., Nick Shaforostoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127666/
> -----------------------------------------------------------
> 
> (Updated April 17, 2016, 11:09 a.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> in ktorrent kcfg_*-names kurlrequester is used to edit a string-typed setting (it may contain only local paths).
> this patch makes sure that no file:// prefix is added on setting change by adding a special check for the case when qvariant contains qurl and converting it appropriately
> 
> 
> Diffs
> -----
> 
>   src/core/kcoreconfigskeleton.cpp 293387b 
> 
> Diff: https://git.reviewboard.kde.org/r/127666/diff/
> 
> 
> Testing
> -------
> 
> ktorrent now displays local paths in settings dialog without file:// prefix
> 
> 
> Thanks,
> 
> Nick Shaforostoff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160418/a67ee456/attachment.html>