Review Request 127655: Fix KAboutData::applicationData() to sync to current Q*Application metadata
Friedrich W. H. Kossebau
kossebau at kde.org
Fri Apr 15 13:06:15 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127655/
-----------------------------------------------------------
Review request for KDE Frameworks.
Repository: kcoreaddons
Description
-------
KAboutData is passed as values on getting and setting the "applicationData",
and it only makes sense to have its properties be a transparent access
to the actual mirrored Q*Application metadata.
Even more as there is code in KF5 (e.g. KXMLGUI) which relies on KAboutData::applicationData(),
without requiring the user to use KAboutData::setApplicationData().
Diffs
-----
autotests/kaboutdatatest.cpp f31e7f3
src/lib/kaboutdata.h 97c0f2b
src/lib/kaboutdata.cpp ceb0c06
Diff: https://git.reviewboard.kde.org/r/127655/diff/
Testing
-------
Added autotests pass.
Thanks,
Friedrich W. H. Kossebau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160415/5bfab713/attachment.html>
More information about the Kde-frameworks-devel
mailing list