Review Request 127606: [kunitconversion] If we don't know a conversion rate, inform the client instead of guessing

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127606/
-----------------------------------------------------------

(Updated April 15, 2016, 1:20 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 878b388ee368bbc9dda0ccdd85fe3e2313da64bc by David Edmundson to branch master.


Repository: kunitconversion


Description
-------

If we can't download a conversion rate for a currency, return
value.isValid() == false.

Current code had some based on the exchange rates of 2013. In many other cases it would be multiplied by a few billion.


Diffs
-----

  autotests/valuetest.h 645b0618a14a0e1e143e02301fbbddfb4539a238 
  autotests/valuetest.cpp a45fd1755b51c88b896b0a17b335ae99dd391c11 
  src/currency.cpp 3b99644a4d32433c074080ab91d92466a6ccc3a9 
  src/value.cpp ec068f871975a2f7b8fd31d8481cc662d13a6fb8 

Diff: https://git.reviewboard.kde.org/r/127606/diff/


Testing
-------

Ran krunner whilst not connected and the cache file deleted. Got no results rather than bogus results.
(Requires an additional one liner in the conversion runner to check result validity)


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160415/dd081a3e/attachment-0001.html>