Review Request 127586: [calendar] Add a mark to days containing events
Martin Gräßlin
mgraesslin at kde.org
Fri Apr 15 05:52:22 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94624
-----------------------------------------------------------
Looks good!
src/declarativeimports/calendar/daysmodel.h (lines 76 - 77)
<https://git.reviewboard.kde.org/r/127586/#comment64315>
maybe move m_lastRequestedEventsStartDate below m_agendaNeedsUpdate? Then you don't have the reordering in the cpp file.
- Martin Gräßlin
On April 15, 2016, 4:28 a.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 4:28 a.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Simple triangle at the bottom right corner, see screenshot.
>
>
> Diffs
> -----
>
> src/declarativeimports/calendar/daysmodel.h 8ab232e
> src/declarativeimports/calendar/daysmodel.cpp bf99874
> src/declarativeimports/calendar/qml/DayDelegate.qml 6353827
> src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4
>
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Screenshot
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160415/8c5252c8/attachment.html>
More information about the Kde-frameworks-devel
mailing list