Review Request 127633: [kpeople] Add a check for PersonData being valid

Aleix Pol Gonzalez aleixpol at kde.org
Mon Apr 11 03:32:06 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127633/#review94512
-----------------------------------------------------------


Ship it!




Ship It!

- Aleix Pol Gonzalez


On April 11, 2016, 4:13 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127633/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 4:13 a.m.)
> 
> 
> Review request for KDE Frameworks and KDEPIM.
> 
> 
> Repository: kpeople
> 
> 
> Description
> -------
> 
> If there is a PersonData that does not have an id,
> it's not a valid person representation.
> 
> 
> Diffs
> -----
> 
>   autotests/persondatatests.cpp 677ee1b 
>   src/persondata.h c3f99a9 
>   src/persondata.cpp e4a0c54 
> 
> Diff: https://git.reviewboard.kde.org/r/127633/diff/
> 
> 
> Testing
> -------
> 
> Tests pass.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160411/5a0158c9/attachment.html>


More information about the Kde-frameworks-devel mailing list