Review Request 127380: More conservative approach to saving some disk accesses
Aleix Pol Gonzalez
aleixpol at kde.org
Sun Apr 10 21:57:37 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127380/
-----------------------------------------------------------
(Updated April 10, 2016, 9:57 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks, Antonio Larrosa Jimenez and Christoph Feck.
Changes
-------
Submitted with commit da3afe6840bf4974bd8d022b86fb9778f2af8688 by Aleix Pol to branch master.
Repository: kiconthemes
Description
-------
My previous approach to KIconThemes felt like a dead end, I decided I'll take a more conservative approach. Here's a first step.
Diffs
-----
autotests/CMakeLists.txt 61e81f6
autotests/kiconloader_benchmark.cpp PRE-CREATION
autotests/kiconloader_unittest.cpp 0e47cc8
src/kiconloader.cpp 75ab482
src/kicontheme.cpp 0996054
Diff: https://git.reviewboard.kde.org/r/127380/diff/
Testing
-------
Attempts to call `KIconThemeDir::iconPath` on the benchmark: 4318 after/5040 before= 17% less QFile::exists
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160410/7d5a81f0/attachment.html>
More information about the Kde-frameworks-devel
mailing list