Review Request 127572: KNewPasswordWidget: override sizeHint()
David Faure
faure at kde.org
Sun Apr 10 12:47:45 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127572/#review94479
-----------------------------------------------------------
src/knewpasswordwidget.cpp (line 271)
<https://git.reviewboard.kde.org/r/127572/#comment64255>
This can't be right. Either they are underneath each other, or next to each other, but not both.
If both have a 100x100 size, you're returning 200x200, which is enough room for 4 sublayouts, not just 2.
Tell me more, why is the default sizeHint not good enough? Isn't there a toplevel layout with these two layouts in it?
- David Faure
On April 10, 2016, 12:38 p.m., Elvis Angelaccio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127572/
> -----------------------------------------------------------
>
> (Updated April 10, 2016, 12:38 p.m.)
>
>
> Review request for KDE Frameworks, Christoph Feck, David Edmundson, David Faure, and Ragnar Thomsen.
>
>
> Repository: kwidgetsaddons
>
>
> Description
> -------
>
> We have an use-case in Ark where the password widget belongs to a vertical layout within a KCollapsibleGroupBox.
> Without this patch, the strength meter bar takes room even if not visible, resulting in a wasted empty space (see screenshots).
>
>
> Diffs
> -----
>
> src/knewpasswordwidget.h acd14105fe9f2d3d212a9667be8b05823c2cb4a8
> src/knewpasswordwidget.cpp 72748d6b9e9fed979bd75ce856867a7bbf9e2fbd
>
> Diff: https://git.reviewboard.kde.org/r/127572/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Before
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/e6462cad-f2c9-4b11-86f9-e49230072b77__knewpasswordwidget-no-hint.png
> After
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/9d9b331a-678f-47f0-9335-87c4bfe16204__knewpasswordwidget-size-hint.png
>
>
> Thanks,
>
> Elvis Angelaccio
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160410/97cc644c/attachment.html>
More information about the Kde-frameworks-devel
mailing list