Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency
John Layt
jlayt at kde.org
Sat Apr 9 11:06:06 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127253/#review94450
-----------------------------------------------------------
Ship it!
Ship It!
- John Layt
On April 7, 2016, 10:53 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127253/
> -----------------------------------------------------------
>
> (Updated April 7, 2016, 10:53 p.m.)
>
>
> Review request for KDE Frameworks, John Layt and Wolfgang Bauer.
>
>
> Bugs: 336016
> https://bugs.kde.org/show_bug.cgi?id=336016
>
>
> Repository: kunitconversion
>
>
> Description
> -------
>
> This adds the "Isreali New Shekel" currency to KUnitConversion.
>
> Patch originally from Wolfgang Ludwig in the linked bug report but adjusted to Frameworks 5.
>
> Added the new unit to the end of the enum for compatibility reasons.
>
>
> Diffs
> -----
>
> src/currency.cpp 3b99644
> src/unit.h 60e849f
>
> Diff: https://git.reviewboard.kde.org/r/127253/diff/
>
>
> Testing
> -------
>
> When I type "5 ILS" into KRunner it spits out correct results, same for "5 sheqel"
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160409/8462852f/attachment.html>
More information about the Kde-frameworks-devel
mailing list