Review Request 127613: Add a test application to render all icons installed on an X11 window

David Faure faure at kde.org
Sat Apr 9 09:47:35 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127613/#review94448
-----------------------------------------------------------


Fix it, then Ship it!




Cool, sounds useful for our discussion about favicons and whether KWindowSystem::setIcons should be deprecated :-)


tests/icontest.cpp (line 3)
<https://git.reviewboard.kde.org/r/127613/#comment64200>

    It's 2016 now ;)


- David Faure


On April 8, 2016, 5:38 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127613/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 5:38 a.m.)
> 
> 
> Review request for KDE Frameworks and David Edmundson.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> This test application extracts all possible icons from an X11 window
> and renders them grouped by the section it belongs to.
> 
> 
> Diffs
> -----
> 
>   tests/CMakeLists.txt 3da38d889f7a973e0bcaef75aeba5632582c6584 
>   tests/icontest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127613/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Example for a Firefox window
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/08/9c410547-b724-4cf9-a710-d9dd34f76cc5__Spectacle.Z13835.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160409/0793d05b/attachment.html>


More information about the Kde-frameworks-devel mailing list