Review Request 127605: [kunitconversion] Fix blocking network file downloading

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127605/
-----------------------------------------------------------

(Updated April 7, 2016, 10:22 p.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks.


Repository: kunitconversion


Description
-------

The current code uses waitForReadyRead on a QNetworkReply which simply
doesn't exist and always returns false.
I don't see how this code could have ever worked.


Diffs
-----

  src/currency.cpp 3b99644a4d32433c074080ab91d92466a6ccc3a9 

Diff: https://git.reviewboard.kde.org/r/127605/diff/


Testing
-------

Ran krunner - finally got valid results


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160407/d4f2b41f/attachment.html>