Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

Kai Uwe Broulik kde at privat.broulik.de
Thu Apr 7 21:53:50 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127253/
-----------------------------------------------------------

(Updated April 7, 2016, 9:53 nachm.)


Review request for KDE Frameworks, John Layt and Wolfgang Bauer.


Changes
-------

Place new enum value where it belongs


Bugs: 336016
    https://bugs.kde.org/show_bug.cgi?id=336016


Repository: kunitconversion


Description
-------

This adds the "Isreali New Shekel" currency to KUnitConversion.

Patch originally from Wolfgang Ludwig in the linked bug report but adjusted to Frameworks 5.

Added the new unit to the end of the enum for compatibility reasons.


Diffs (updated)
-----

  src/currency.cpp 3b99644 
  src/unit.h 60e849f 

Diff: https://git.reviewboard.kde.org/r/127253/diff/


Testing
-------

When I type "5 ILS" into KRunner it spits out correct results, same for "5 sheqel"


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160407/a0036711/attachment.html>


More information about the Kde-frameworks-devel mailing list