Review Request 127605: [kunitconversion] Fix blocking network file downloading

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127605/#review94388
-----------------------------------------------------------




src/currency.cpp (line 656)
<https://git.reviewboard.kde.org/r/127605/#comment64173>

    Maybe it would make sense to use QNetworkManager to write the file as well? This way we can use the async API.



src/currency.cpp (line 689)
<https://git.reviewboard.kde.org/r/127605/#comment64172>

    unrelated?


- Aleix Pol Gonzalez


On April 7, 2016, 5:58 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127605/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 5:58 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> -------
> 
> The current code uses waitForReadyRead on a QNetworkReply which simply
> doesn't exist and always returns false.
> I don't see how this code could have ever worked.
> 
> 
> Diffs
> -----
> 
>   src/currency.cpp 3b99644a4d32433c074080ab91d92466a6ccc3a9 
> 
> Diff: https://git.reviewboard.kde.org/r/127605/diff/
> 
> 
> Testing
> -------
> 
> Ran krunner - finally got valid results
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160407/ab609024/attachment-0001.html>