Review Request 127603: [kunitconversion] Create relevant cache dir for libkunitconversion before trying to use it

Aleix Pol Gonzalez aleixpol at kde.org
Thu Apr 7 16:00:36 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127603/#review94386
-----------------------------------------------------------



+1 otherwise


src/currency.cpp (line 50)
<https://git.reviewboard.kde.org/r/127603/#comment64170>

    Move to initializer and make attributes const?


- Aleix Pol Gonzalez


On April 7, 2016, 5:58 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127603/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 5:58 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> -------
> 
> Otherwise cache file is not saved
> 
> 
> Diffs
> -----
> 
>   src/currency.cpp 3b99644a4d32433c074080ab91d92466a6ccc3a9 
> 
> Diff: https://git.reviewboard.kde.org/r/127603/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160407/f7c467eb/attachment.html>


More information about the Kde-frameworks-devel mailing list