Review Request 127597: Fix generation of path to xcb plugin
Aleix Pol Gonzalez
aleixpol at kde.org
Thu Apr 7 14:40:43 UTC 2016
> On April 7, 2016, 2:17 p.m., Heiko Becker wrote:
> > Wouldn't \{$KDE_INSTALL_FULL_PLUGINDIR\}/kf5/org.kde.k... be better suited to solve the relative/absolute PLUGINDIR issue?
>
> Martin Gräßlin wrote:
> that generates a proper absolute path. I don't know about the relative path, though.
Yes, what Heiko suggests is better.
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127597/#review94371
-----------------------------------------------------------
On April 7, 2016, 9:55 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127597/
> -----------------------------------------------------------
>
> (Updated April 7, 2016, 9:55 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kwindowsystem
>
>
> Description
> -------
>
> The path was wrong which is the reason why X11 windows don't have
> icons in kwin_wayland.
>
>
> Diffs
> -----
>
> src/config-kwindowsystem.h.cmake 9afe81f9757de5e8e2d9387aa5c641955da08164
>
> Diff: https://git.reviewboard.kde.org/r/127597/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160407/83ab3c4a/attachment.html>
More information about the Kde-frameworks-devel
mailing list