Review Request 127597: Fix generation of path to xcb plugin

Aleix Pol Gonzalez aleixpol at kde.org
Thu Apr 7 11:29:23 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127597/#review94370
-----------------------------------------------------------


Ship it!




Generating the path at compile time doesn't look very elegant, though...

- Aleix Pol Gonzalez


On April 7, 2016, 9:55 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127597/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 9:55 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> The path was wrong which is the reason why X11 windows don't have
> icons in kwin_wayland.
> 
> 
> Diffs
> -----
> 
>   src/config-kwindowsystem.h.cmake 9afe81f9757de5e8e2d9387aa5c641955da08164 
> 
> Diff: https://git.reviewboard.kde.org/r/127597/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160407/287fc406/attachment.html>


More information about the Kde-frameworks-devel mailing list