Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

[John Layt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127253/#review94364
-----------------------------------------------------------



One correction to the enum.


src/unit.h (line 158)
<https://git.reviewboard.kde.org/r/127253/#comment64161>

    This can be added to the end of the Currency group and still be BIC, that's why each group is hard-coded to start at a 1000 interval.


- John Layt


On March 2, 2016, 1:17 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127253/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 1:17 a.m.)
> 
> 
> Review request for KDE Frameworks, John Layt and Wolfgang Bauer.
> 
> 
> Bugs: 336016
>     https://bugs.kde.org/show_bug.cgi?id=336016
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> -------
> 
> This adds the "Isreali New Shekel" currency to KUnitConversion.
> 
> Patch originally from Wolfgang Ludwig in the linked bug report but adjusted to Frameworks 5.
> 
> Added the new unit to the end of the enum for compatibility reasons.
> 
> 
> Diffs
> -----
> 
>   src/currency.cpp 3b99644 
>   src/unit.h 9e17624 
> 
> Diff: https://git.reviewboard.kde.org/r/127253/diff/
> 
> 
> Testing
> -------
> 
> When I type "5 ILS" into KRunner it spits out correct results, same for "5 sheqel"
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160407/f6b8ae75/attachment.html>