Review Request 127560: Remove U(...) macro.

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127560/
-----------------------------------------------------------

(Updated April 4, 2016, 10:57 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and John Layt.


Changes
-------

Submitted with commit 3a5db6d8301dd323137fd4fa2c06332b08b833f1 by Andreas Cord-Landwehr to branch master.


Repository: kunitconversion


Description
-------

This unprefixed macro in a public header causes problem, once you are
using capital U as an object name and calling its constructor (e.g.,
when using Eigen headers where capital U is commong for matrices).

Remove macro, since it is not used in KUnitConversion.


Diffs
-----

  src/unit.h 9e176244165769b9e93c8ce828c6b2ac36f85a8a 

Diff: https://git.reviewboard.kde.org/r/127560/diff/


Testing
-------

Tested clean build of KUnitConversion, grepping for "U(" within framworks also did not return any problem. Yet, I cannot judge if this macro is used anywhere out of KF5.
Removing this macro also fixes my build of Kalzium, where the macro crashes with Eigen headers.


Thanks,

Andreas Cord-Landwehr

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160404/81bbe399/attachment.html>