Review Request 127573: Don't crash if we have no openGL context

[David Edmundson]

> On April 4, 2016, 4:26 p.m., Kai Uwe Broulik wrote:
> > Should we add a property "supported" or similar so we can check whether the item works?
> > 
> > I know we don't want to go down the "make tons of adjustments for 2d renderer"-route but so at least Plasma NM could hide the tab so it doesn't look as broken.

Maybe. I'm not sure.

That current method wouldn't work, and we can't just move this call to the constructor as there's no opengl context till the scenegraph is initialised on the window anyway. Do-able but it gets a bit more complex.

Other problem is that the network manager tab is lazy loaded, in order to sometimes hide the tab, we'd have to load the contents first, which would suck.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127573/#review94246
-----------------------------------------------------------


On April 4, 2016, 3:21 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127573/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 3:21 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> This means Plasma can be used with the QtQuick 2D renderer, albeit with
> slightly missing functionality.
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrolsaddons/plotter.cpp 233dd6b9bc0dbeddcbeb8ee02ebc500bf10282b3 
> 
> Diff: https://git.reviewboard.kde.org/r/127573/diff/
> 
> 
> Testing
> -------
> 
> Ran plasmashell with the 2d renderer.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160404/6b223281/attachment-0001.html>