Review Request 127514: Skip category test if no restriction is set.

Alex Richardson arichardson.kde at gmail.com
Sun Apr 3 21:19:50 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127514/#review94223
-----------------------------------------------------------


Ship it!




Ship It!

- Alex Richardson


On April 3, 2016, 9:54 a.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127514/
> -----------------------------------------------------------
> 
> (Updated April 3, 2016, 9:54 a.m.)
> 
> 
> Review request for KDE Frameworks and Alex Richardson.
> 
> 
> Repository: kcmutils
> 
> 
> Description
> -------
> 
> Align the method's logic with the API documentation for
> KPluginSelector::addPlugins. The intended behavior is that
> if no categoryKey is set, the category key test is skipped.
> 
> 
> Diffs
> -----
> 
>   src/kpluginselector.cpp a893e381d1376ccc5c8189b638609e141c198282 
> 
> Diff: https://git.reviewboard.kde.org/r/127514/diff/
> 
> 
> Testing
> -------
> 
> Manual testing in Parley.
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160403/fca088ef/attachment.html>


More information about the Kde-frameworks-devel mailing list