Review Request 127560: Remove U(...) macro.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127560/#review94214
-----------------------------------------------------------



The rest of frameworks is the wrong place to grep, please grep the files/dirs listed in https://lxr.kde.org/search?_filestring=&_string=KUnitConversion

- David Faure


On April 3, 2016, 9:06 a.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127560/
> -----------------------------------------------------------
> 
> (Updated April 3, 2016, 9:06 a.m.)
> 
> 
> Review request for KDE Frameworks and John Layt.
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> -------
> 
> This unprefixed macro in a public header causes problem, once you are
> using capital U as an object name and calling its constructor (e.g.,
> when using Eigen headers where capital U is commong for matrices).
> 
> Remove macro, since it is not used in KUnitConversion.
> 
> 
> Diffs
> -----
> 
>   src/unit.h 9e176244165769b9e93c8ce828c6b2ac36f85a8a 
> 
> Diff: https://git.reviewboard.kde.org/r/127560/diff/
> 
> 
> Testing
> -------
> 
> Tested clean build of KUnitConversion, grepping for "U(" within framworks also did not return any problem. Yet, I cannot judge if this macro is used anywhere out of KF5.
> Removing this macro also fixes my build of Kalzium, where the macro crashes with Eigen headers.
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160403/7d5239dc/attachment.html>