Review Request 127548: Take content margins into account when calcuating size hints

[Ragnar Thomsen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127548/#review94187
-----------------------------------------------------------


Ship it!




Yes, works perfectly :)

- Ragnar Thomsen


On April 1, 2016, 5:04 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127548/
> -----------------------------------------------------------
> 
> (Updated April 1, 2016, 5:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Ragnar Thomsen.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> We set the contentsMargins to be the size of the header ">" arrow. However as we didn't take this into account with the sizeHint items were slightly smaller than they should be which led to them being truncated early.
> 
> The test has also been updated to include an example of a case which failed.
> 
> 
> Diffs
> -----
> 
>   src/kcollapsiblegroupbox.cpp edda7af15af1a91d9af8ba4d7dc807a3f2ee9f28 
>   tests/kcollapsiblegroupboxtest.cpp ffd7bd0bf6fe02075047d68264aa1c18b948bd46 
> 
> Diff: https://git.reviewboard.kde.org/r/127548/diff/
> 
> 
> Testing
> -------
> 
> Updated test.
> 
> Rthomsen has a use case in Ark which exhibited this bug, so hopefully he can test and report back.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160401/00693cbe/attachment.html>