Review Request 124941: Reparse notification config only when actually needed
Martin Klapetek
martin.klapetek at gmail.com
Mon Sep 28 18:16:20 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124941/
-----------------------------------------------------------
(Updated Sept. 28, 2015, 6:16 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Changes
-------
Submitted with commit da3a2f7dc3a8635d928e3a2fa334b1bbb16301d6 by Martin Klapetek to branch master.
Repository: knotifications
Description
-------
Till now every KNotification::notify() call would reparse the whole cache of configs. With this patch it watches for KNotifyConfig changes and reparses only those configs that had actually changed.
Diffs
-----
src/knotificationmanager.cpp 4c648a9
src/knotificationmanager_p.h 95e13d1
src/knotifyconfig.h fae17cb
src/knotifyconfig.cpp 6a46a00
Diff: https://git.reviewboard.kde.org/r/124941/diff/
Testing
-------
Works as expected.
Thanks,
Martin Klapetek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150928/9365acfc/attachment.html>
More information about the Kde-frameworks-devel
mailing list