Review Request 125417: Don't sync the config n times when saving

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125417/
-----------------------------------------------------------

(Updated Sept. 27, 2015, 12:42 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 0cec8ea4caee4eaaf6af7df90830bd21a9a0db53 by David Edmundson to branch master.


Repository: knotifyconfig


Description
-------

Because knotifyconfigelement has a cache, we end up calling writeEntry; sync() ; writeEntry() ; sync() ..which sounds expensive 

This change makes that we only sync after all the writeEntry.


Diffs
-----

  src/knotifyconfigelement.cpp 93fade5b2b02ea9acfb8f11dee5879aca6c0d807 
  src/knotifyeventlist.cpp dd6b6e9d5557fde0b46d980e4078921dd978f13f 

Diff: https://git.reviewboard.kde.org/r/125417/diff/


Testing
-------

Still works.
Nothing else called NotifyConfigElement::save and it's private API.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150927/6add6532/attachment.html>