Review Request 124788: Replace std::auto_ptr with std::unique_ptr

Harald Sitter sitter at kde.org
Tue Sep 22 10:39:06 UTC 2015



> On Sept. 22, 2015, 9:54 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> > Ship It!

pushed. please mark the review as submitted. someone forgot to add the commit trigger, so it won't auto-close XD


- Harald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124788/#review85738
-----------------------------------------------------------


On Sept. 22, 2015, 8:25 a.m., Armin K. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124788/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 8:25 a.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: khtml
> 
> 
> Description
> -------
> 
> std::auto_ptr is deprecated and this patch silences a number of compiler warnings when using GCC-5.x.
> 
> Other frameworks use std::unique_ptr too and no public headers were changed in the process.
> 
> 
> Diffs
> -----
> 
>   src/svg/SVGDocumentExtensions.h 71ad134 
>   src/svg/SVGDocumentExtensions.cpp 935fb20 
>   src/svg/SVGElement.cpp 2d2e4b3 
>   src/svg/SVGMaskElement.h 850df29 
>   src/svg/SVGMaskElement.cpp e6039d7 
>   src/svg/SVGPatternElement.cpp 5773b9f 
>   src/svg/graphics/SVGPaintServerPattern.h 5ba655f 
>   src/svg/graphics/SVGPaintServerPattern.cpp 7fcd4f3 
> 
> Diff: https://git.reviewboard.kde.org/r/124788/diff/
> 
> 
> Testing
> -------
> 
> It builds!
> 
> 
> Thanks,
> 
> Armin K.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150922/07aa7bdc/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list