Review Request 125343: bump so version from 5 to 6

John Layt jlayt at kde.org
Tue Sep 22 08:31:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125343/#review85736
-----------------------------------------------------------


Will have a proper look when I get home tonight, what was the so number when released as part of kdepimlibs4? Was it 4 or 5? If 4 then we can stay at 5 as KHolidays has never been officially released for KF5? Or will we get this issue with every PIM library that was in the unofficial release? (And there were more abi changes than just the removal of the widget).

- John Layt


On Sept. 22, 2015, 9:02 a.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125343/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 9:02 a.m.)
> 
> 
> Review request for KDE Frameworks, Daniel Vrátil and John Layt.
> 
> 
> Repository: kholidays
> 
> 
> Description
> -------
> 
> since Applications/15.08 KHolidays::HolidayRegionSelector was removed
> constituting an incompatible change.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ebd4b8981a658665a42140250b6eb3d92662e607 
> 
> Diff: https://git.reviewboard.kde.org/r/125343/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150922/111dae8f/attachment.html>


More information about the Kde-frameworks-devel mailing list