Review Request 125332: Use the more advanced version of uriencode.cmake from kdoctools which supports Windows.

Luigi Toscano luigi.toscano at tiscali.it
Mon Sep 21 22:21:10 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125332/#review85729
-----------------------------------------------------------


So basically this is:
* "synchronization" with the last changes in kdoctools (fix to encoding function, search for Perl modules).
* use of the encoding function (*_encode_uri()) on the other variable which is replaced, and application of the same pattern (complicated due to the different build and runtime directories).

Can you please fix the comment then (and/or add some other comments)? Just another check and then I guess we are good to go.

- Luigi Toscano


On Set. 21, 2015, 2:41 p.m., Patrick von Reth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125332/
> -----------------------------------------------------------
> 
> (Updated Set. 21, 2015, 2:41 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> -------
> 
> Use the more advanced version of uriencode.cmake from kdoctools which supports Windows.
> 
> 
> Diffs
> -----
> 
>   cmake/FindPerlModules.cmake PRE-CREATION 
>   cmake/uriencode.cmake fde06d3ccf14212122bbee583b44158a2411fbcf 
>   src/CMakeLists.txt 14cc57413b827286ba1d29ccf31e308b05c52413 
> 
> Diff: https://git.reviewboard.kde.org/r/125332/diff/
> 
> 
> Testing
> -------
> 
> Windows
> 
> 
> Thanks,
> 
> Patrick von Reth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150921/6b28c384/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list