Review Request 125300: Fix lock in KProtocolManager

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125300/
-----------------------------------------------------------

(Updated Sept. 21, 2015, 4:34 p.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks.


Bugs: 350890
    https://bugs.kde.org/show_bug.cgi?id=350890


Repository: kio


Description
-------

We had a non-recursive mutex and we kept requesting it. Eventually it locked because we were locking the mutex when already locked.

An alternative fix could be to rearrange the code and release it sooner, but it doesn't seem worth it. (although I had to remove 2 asserts and I feel uneasy about it).


Diffs
-----

  src/core/kprotocolmanager.cpp 294ebdf 

Diff: https://git.reviewboard.kde.org/r/125300/diff/


Testing
-------

Tests pass, cannot reproduce the attached bug anymore.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150921/f7cd53ce/attachment.html>