Review Request 125316: KProtocolManager: fix deadlock when using EnvVarProxy.

Aleix Pol Gonzalez aleixpol at kde.org
Mon Sep 21 14:34:34 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125316/#review85717
-----------------------------------------------------------

Ship it!


Looks good to me, seems to fix the issue. I'll discard my patch.

- Aleix Pol Gonzalez


On Sept. 21, 2015, 3:23 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125316/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 3:23 p.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Bugs: 350890
>     https://bugs.kde.org/show_bug.cgi?id=350890
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> BUG: 350890
> Change-Id: I8471c01d68054c7dccb9109524f0433465219aff
> FIXED-IN: 5.15
> 
> 
> Diffs
> -----
> 
>   autotests/kprotocolinfotest.cpp 1efd91094db17a7f2c5a008f35de8f6a86a91f12 
>   src/core/kprotocolmanager.cpp 294ebdfd9de53aeb560211fbd0df17a590650a27 
> 
> Diff: https://git.reviewboard.kde.org/r/125316/diff/
> 
> 
> Testing
> -------
> 
> unittest
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150921/11110317/attachment.html>


More information about the Kde-frameworks-devel mailing list