Review Request 125332: Use the more advanced version of uriencode.cmake from kdoctools which supports Windows.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125332/#review85715
-----------------------------------------------------------



cmake/FindPerlModules.cmake (line 2)
<https://git.reviewboard.kde.org/r/125332/#comment59239>

    How is that new file related?



cmake/uriencode.cmake (line 2)
<https://git.reviewboard.kde.org/r/125332/#comment59237>

    should be kdelibs4support_encode_uri



src/CMakeLists.txt (line 645)
<https://git.reviewboard.kde.org/r/125332/#comment59238>

    That doesn't seem to make a lot of sense...


- Aleix Pol Gonzalez


On Sept. 21, 2015, 2:41 p.m., Patrick von Reth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125332/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 2:41 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> -------
> 
> Use the more advanced version of uriencode.cmake from kdoctools which supports Windows.
> 
> 
> Diffs
> -----
> 
>   cmake/FindPerlModules.cmake PRE-CREATION 
>   cmake/uriencode.cmake fde06d3ccf14212122bbee583b44158a2411fbcf 
>   src/CMakeLists.txt 14cc57413b827286ba1d29ccf31e308b05c52413 
> 
> Diff: https://git.reviewboard.kde.org/r/125332/diff/
> 
> 
> Testing
> -------
> 
> Windows
> 
> 
> Thanks,
> 
> Patrick von Reth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150921/0ba9509a/attachment.html>