Review Request 125318: KBuildSycocaProgressDialog: use Qt's builtin busy indicator.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125318/
-----------------------------------------------------------

(Updated Sept. 20, 2015, 5:36 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Albert Astals Cid.


Changes
-------

Submitted with commit 4c01cfa9bc20b1420ac8113676ebfb66363a3c82 by David Faure to branch master.


Repository: kio


Description
-------

This makes the code much simpler and looks better to the user
than a fake progress.

Also removed the 1s delay before closing the dialog.
Users like fast, not slow ;)

BUG: 158672
Change-Id: I4a5cc975239d5c2998cdc3079890834c23ae677d
REVIEW: 125318
FIXED-IN: 5.15


Diffs
-----

  src/widgets/kbuildsycocaprogressdialog.h 88c5087990c01725e065fc650e63de246b3032e1 
  src/widgets/kbuildsycocaprogressdialog.cpp 78d23dfda174f195e4c7fdfc1e128e83194326f3 

Diff: https://git.reviewboard.kde.org/r/125318/diff/


Testing
-------

kio/tests/ksycocaupdatetest, after deleting ksycoca so that it doesn't end too fast ;)


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150920/48b75822/attachment.html>