Review Request 125325: New widget KCollapsibleGroupBox

[Sune Vuorela]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/#review85688
-----------------------------------------------------------


I like the concept.


src/kcollapsiblegroupbox.h (line 4)
<https://git.reviewboard.kde.org/r/125325/#comment59201>

    trailing whitespace



src/kcollapsiblegroupbox.h (line 6)
<https://git.reviewboard.kde.org/r/125325/#comment59205>

    widgetaddons is lgpl, not gpl



src/kcollapsiblegroupbox.h (line 12)
<https://git.reviewboard.kde.org/r/125325/#comment59202>

    whitespace



src/kcollapsiblegroupbox.h (line 17)
<https://git.reviewboard.kde.org/r/125325/#comment59203>

    whitespace



src/kcollapsiblegroupbox.h (line 20)
<https://git.reviewboard.kde.org/r/125325/#comment59204>

    whitespace



src/kcollapsiblegroupbox.h (line 34)
<https://git.reviewboard.kde.org/r/125325/#comment59208>

    Does it handle 1000 items, or is it up to the user to ensure to limit it or add it in a scrollarea?
    Should it be documented?



src/kcollapsiblegroupbox.h (line 65)
<https://git.reviewboard.kde.org/r/125325/#comment59207>

    Missing words? Or too many?



src/kcollapsiblegroupbox.h (line 100)
<https://git.reviewboard.kde.org/r/125325/#comment59206>

    This construct actually EXPORT's the private class as well. The easy way is to move the class outside of the public class as KCollapsibleGroupBoxPrivate. The harder way is to ... build the right NOT_EXPORT macro


- Sune Vuorela


On Sept. 20, 2015, 1:48 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125325/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2015, 1:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> A groupbox featuring a clickable header and arrow indicator that can be
> expanded and collapsed to reveal the box content
> 
> Widget features a close and collapse animation and works as expected in
> QtDesigner.
> 
> --
> Screenshot explains what I mean better than the description above.
> 
> I've been given at least 3 mockups from the VDG mockup which feature using this widget, clearly there's a demand for it. 
> 
> It's a bit like QToolBox, except no-one uses it because QToolbox has a weird way of only expanding one at a time, and looks a bit weird so no-one uses it.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
>   src/kcollapsiblegroupbox.h PRE-CREATION 
>   src/kcollapsiblegroupbox.cpp PRE-CREATION 
>   tests/CMakeLists.txt 180b0ef1f8900247da59112612ee87dd3164c8af 
>   tests/kcollapsiblegroupboxtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125325/diff/
> 
> 
> Testing
> -------
> 
> Made little test app (see screenshot)
> 
> Wrote QtDesigner plugin, and played with it there.
> 
> 
> File Attachments
> ----------------
> 
> kcollapsiblegroupbox.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150920/d49c3577/attachment-0001.html>